20250307-misc-xorbuf-optimizer#8540
Merged
dgarske merged 3 commits intowolfSSL:masterfrom Mar 8, 2025
Merged
Conversation
dgarske
previously approved these changes
Mar 7, 2025
douzzer
force-pushed
the
20250307-misc-xorbuf-optimizer
branch
2 times, most recently
from
1dd1446 to
563c409
Compare
Contributor
Author
|
retest this please (numerous |
…rectly via a simplified path if all args are already aligned to WOLFSSL_WORD_SIZE (fixes performance regression from dc2e263). configure.ac: add a "Conflicting asm settings" error check at end, since our configuration currently blows up if --enable-intelasm and --disable-asm are combined.
…ings", for backward compatibility.
Contributor
Author
|
retest this please ( |
…4 scenario, then the test script wedged on retry after successfully make checking.
douzzer
force-pushed
the
20250307-misc-xorbuf-optimizer
branch
from
5db1d76 to
a84831c
Compare
Contributor
Author
|
retest this please ( |
dgarske
approved these changes
Mar 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wolfcrypt/src/misc.c: inxorbufout()andxorbuf(), callXorWords()directly via a simplified path if all args are already aligned toWOLFSSL_WORD_SIZE(fixes performance regression from dc2e263).configure.ac: add a "Conflicting asm settings" error check at end, since our configuration currently blows up if--enable-intelasmand--disable-asmare combined.tested with
wolfssl-multi-test.sh ... benchmark-wolfcrypt-intelasm-all super-quick-check